Open
Conversation
Copilot created this pull request from a session on behalf of
szaimen
March 23, 2026 11:04
View session
Copilot stopped work on behalf of
szaimen due to an error
March 23, 2026 11:38
Copilot stopped work on behalf of
szaimen due to an error
March 23, 2026 13:53
Copilot stopped work on behalf of
szaimen due to an error
March 23, 2026 14:06
Copilot stopped work on behalf of
szaimen due to an error
March 23, 2026 14:09
Copilot stopped work on behalf of
szaimen due to an error
March 23, 2026 15:19
Agent-Logs-Url: https://github.com/nextcloud/files_pdfviewer/sessions/85bfdeb5-cb86-47bd-a400-21fd635e8738 Fix e2e tests: use page.request instead of unauthenticated request fixture Agent-Logs-Url: https://github.com/nextcloud/files_pdfviewer/sessions/9f11c286-c7cf-4c83-8a23-60b7561576da Work in progress: debugging e2e test failures Agent-Logs-Url: https://github.com/nextcloud/files_pdfviewer/sessions/d85259e6-86f6-4396-985a-7c895c8c4c6e Fix e2e tests: use standalone request fixture with Basic Auth for WebDAV and OCS API calls; enable files_pdfviewer in setup Agent-Logs-Url: https://github.com/nextcloud/files_pdfviewer/sessions/d85259e6-86f6-4396-985a-7c895c8c4c6e Fix file-click interaction in e2e test for NC34: use data-cy-files-list-row-name-link selector Agent-Logs-Url: https://github.com/nextcloud/files_pdfviewer/sessions/812ab538-05bb-48b3-8f48-1bd46f2f5fe0 chore(e2e): investigate failing e2e tests — root cause identified, no fix applied Agent-Logs-Url: https://github.com/nextcloud/files_pdfviewer/sessions/f14e7f86-d7c3-4540-a2f2-dbcd359b105c chore(e2e): update start-nextcloud-server.mjs to mirror nextcloud/text pattern - Import and call `waitOnNextcloud` to ensure NC is ready before tests start - Import and call `configureNextcloud(['viewer', 'files_pdfviewer'])` in startup script - Use `git ls-remote --refs` to check if `stable${maxVersion}` branch exists; fall back to `master` if not (with error handling for offline environments) - Add SIGTERM/SIGINT handlers for clean container shutdown - Remove debug.spec.ts (investigation-only file from previous session) Agent-Logs-Url: https://github.com/nextcloud/files_pdfviewer/sessions/511d0124-9021-405e-9a82-4ef2221ffb66 Co-Authored-By: szaimen <42591237+szaimen@users.noreply.github.com>
szaimen
force-pushed
the
copilot/add-e2e-tests-pdfviewer
branch
from
d5f1b08 to
55b3253
Compare
szaimen
requested review from
AndyScherzinger,
ShGKme and
danxuliu
and removed request for
szaimen
Collaborator
|
This is ready for review :) |
nickvergessen
requested changes
Mar 30, 2026
Comment on lines
+26
to
+31
| [[annotations]] | ||
| path = [".github/workflows/playwright.yml"] | ||
| precedence = "aggregate" | ||
| SPDX-FileCopyrightText = "2025 Nextcloud GmbH and Nextcloud contributors" | ||
| SPDX-License-Identifier = "MIT" | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| [[annotations]] | |
| path = [".github/workflows/playwright.yml"] | |
| precedence = "aggregate" | |
| SPDX-FileCopyrightText = "2025 Nextcloud GmbH and Nextcloud contributors" | |
| SPDX-License-Identifier = "MIT" |
Should be in the workflows file.
Edit: Actually it is, so remove here
| continue-on-error: true | ||
| with: | ||
| filters: | | ||
| src: |
Member
There was a problem hiding this comment.
This summarizes to "always".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Playwright e2e tests for PDF viewer